added item pagination with 10 items per page and 4 buttons to select from along with arrows #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from along with arrows
stevem-zhou
requested changes
May 27, 2024
|
I've added the scrolling functionality and I got rid of the extra space. I was getting errors of undefined lat on the map while I was developing so I made a little change on the Map.jsx file to fix it. |
stevem-zhou
requested changes
Jun 2, 2024
There was a problem hiding this comment.
since we have agreed to go with pagination, please fix the bugs that we have found during the meeting:
- - search bar not working with pagination
- - number of pages would change depending on search
- - rerender the page numbers
- - filtering as well
- - button to go straight to first item or last
- - … button to specify page (user can input page number)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #25
here is what the pagination looks like:
